Have you tested on 4.4?

@Stypox: Not thoroughly, but I was going to.

Reading licenses is broken :/

Edit: I partially fixed that, however it shows nothing on my phone as soon as I add any stylesheet. It currently works on an Android 4.4 AVD though, which was crashing before, but I didn't test it in any other AVDs yet.

Edit 2: the issue on my phone doesn't happen when reverting compile/targetSdkVersion to 28. Ughhh…

Edit 3: it happens in an Android 10 AVD as well, so at least it's not some Samsung bullshit.

Edit 4: it apparently needs to be base64-encoded since Android 10, so I did that now.

is there a protocol that can be followed to fully test such app-wide changes?

@Stypox Test everything on KitKat, Lollipop, latest and a version (maybe Oreo) in between. With so many upgraded dependencies almost everything is somehow affected by this change.

@TobiGr: I think he meant more like what is "everything"? NewPipe has so many features that you could easily forget one.

Btw I also tested on my 7.0 phone and everything works fine

Tested on 9.0 phone and Android TV 7.1.2 and I haven't found an issue.

I tested it on AVD API 19 and on my phone with Android 10. I'll rebase and do what @Stypox suggested.

On KitKat main page tabs are not loaded again when new tabs are added through the settings.
E.g. I added the history tab and moved it to the top of the list. Instead of seeing the history when going back, I see trending content.

@TobiGr: I just rebased, but I can't reproduce your bug.

@TobiGr I think this has to do with #3312 and is unrelated from this PR.